Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump min version of google-api-core and google-cloud-core to 2.x #1972

Merged
merged 1 commit into from
Jul 10, 2024
Merged

deps: bump min version of google-api-core and google-cloud-core to 2.x #1972

merged 1 commit into from
Jul 10, 2024

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jul 10, 2024

Fixes constraints file to match setup.py

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards googleapis/python-aiplatform#4079 🦕

@tswast tswast requested review from a team as code owners July 10, 2024 16:21
@tswast tswast requested a review from chalmerlowe July 10, 2024 16:21
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jul 10, 2024
Linchin
Linchin approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@Linchin Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing the issue so quickly!

For posterity, what is the process to update the required dependency versions?

@Linchin Linchin merged commit a958732 into main Jul 10, 2024
21 checks passed
@Linchin Linchin deleted the tswast-constraints branch July 10, 2024 18:20
@release-please release-please bot mentioned this pull request Jul 10, 2024
Merged
@tswast
Copy link
Contributor Author

tswast commented Jul 10, 2024

For posterity, what is the process to update the required dependency versions?

@Linchin Main thing is that when updating setup.py, make sure to update constraints.txt for the minimum supported Python version. Note: the tests validate via constraints.txt, so if you find yourself wanting to update one of those, make sure you make the corresponding change in setup.py.

See: googleapis/gapic-generator-python#1788 for a hint at how this works in the generated clients as well as googleapis/synthtool#1901 to apply these minimum version constraints checks via the synthtool templated files.

@tswast tswast mentioned this pull request Jul 10, 2024
Open
@tswast
Copy link
Contributor Author

tswast commented Jul 10, 2024

I've filed #1974 for another layer of automated testing.

This was referenced Oct 1, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linchin Linchin Linchin approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe chalmerlowe is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@hongalex hongalex

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @Linchin @hongalex